Add zh_TW Traditional Chinese locale #6773
Conversation
|
Do you accept being on the zh_TW localization team @PeterDaveHello for future review? |
Sure! |
|
@pluiedev I can help maintain it ;) |
|
Yeah, what I mean is that we should ideally have one other person to serve as a co-translator or a proofreader to ensure the quality of translations. |
|
Ideally, every role should have at least one backup. However, I'm unsure if this should be a strict requirement in practice. As you know, this is an open-source project supported by volunteers. Therefore, perhaps we can consider it as an additional, non-mandatory task. |
|
Another thought that may be helpful: as an open source projects maintainer who doesn't understand more than two languages, those frontier LLMs are my friends to help proofread. They may not be able to translate perfectly, but they're very helpful in checking whether the translations are understandable, reasonable, and improved. |
Yeah absolutely. I'd love to see a GH bot or something (maybe it exists) that does this specifically for PO files since they're an all known format. I do it manually right now (I've run a handful of our PRs through an LLM) and its helpful but having something more automated and in the loop would be a great help. |
Maybe take a look at https://www.qodo.ai/ and https://coderabbit.ai/, though they aren't designed for the po files, they absolutely can and will help review translation, additionally, also for the other changes in the project. |
|
@mitchellh @pluiedev, with respect, is there any chance we can move on? As there seemed to be merge conflict now, I'm not sure if it should be resolved ;) |
There was a problem hiding this comment.
Awesome translation! There are just a few points to discuss :)
Regarding the merge conflict issues, I suggest discarding the file i18n.zig, rebasing to the main branch, and then reapplying this patch. After that, this PR will be mergeable, and the maintainer won't need to rebase it manually.
git am 0001-l10n-add-zh-TW-entry.patch|
|
||
| #: src/apprt/gtk/CloseDialog.zig:90 | ||
| msgid "Close Split?" | ||
| msgstr "是否要關閉分割區？" |
There was a problem hiding this comment.
I propose 分割窗格, where 窗格 is pane:
A pane is a (usually) independently scrollable subsection of a window.
| #: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:33 | ||
| #: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:45 | ||
| msgid "Change Title…" | ||
| msgstr "變更標題……" |
There was a problem hiding this comment.
"Change Title…" might open a new popup that allows users to change the title. In this case, I suggest using three dots for a shorter menu label.
| #: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:38 | ||
| #: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:50 | ||
| msgid "Split Up" | ||
| msgstr "向上分割" |
There was a problem hiding this comment.
According to the behavior of this button, I propose 切出 <direction> 窗格 so users understand its function. For example, 切出左窗格. "向上分割" often does not convey its meaning clearly.
|
We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait. @pan93412 you seem knowledgable as well, do you volunteer to be notified for further review? Would also be happy to have your contributions to further improve this. |
Sure, thank you :) I believe this translation is quite good. Most of my suggestions are just minor tweaks. I will approve it now. |
|
We're getting a couple translation errors @PeterDaveHello. Can you review the CI failures and ensure the po is up to date? |
I have added some strings from the latest pot file, making the Diff--- zh_TW.UTF-8.po 2025-04-12 00:56:13
+++ zh_TW.UTF-8.patched.po 2025-04-12 00:59:06
@@ -8,14 +8,15 @@
msgstr ""
"Project-Id-Version: com.mitchellh.ghostty\n"
"Report-Msgid-Bugs-To: [email protected]\n"
-"POT-Creation-Date: 2025-03-06 20:10+0100\n"
-"PO-Revision-Date: 2025-03-17 22:07+0800\n"
-"Last-Translator: Peter Dave Hello <[email protected]>\n"
+"POT-Creation-Date: 2025-03-19 08:54-0700\n"
+"PO-Revision-Date: 2025-04-12 00:59+0800\n"
+"Last-Translator: Yi-Jyun Pan <[email protected]>\n"
"Language-Team: Chinese (traditional)\n"
"Language: zh_TW\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
+"X-Generator: Poedit 3.6\n"
#: src/apprt/gtk/ui/1.5/prompt-title-dialog.blp:5
msgid "Change Terminal Title"
@@ -34,6 +35,28 @@
msgid "OK"
msgstr "確定"
+#: src/apprt/gtk/ui/1.5/config-errors-dialog.blp:5
+msgid "Configuration Errors"
+msgstr "設定錯誤"
+
+#: src/apprt/gtk/ui/1.5/config-errors-dialog.blp:6
+msgid ""
+"One or more configuration errors were found. Please review the errors below, "
+"and either reload your configuration or ignore these errors."
+msgstr ""
+"您的設定有一或多個錯誤。請檢閱下述錯誤，並選擇要重新載入設定，還是忽略這些錯"
+"誤。"
+
+#: src/apprt/gtk/ui/1.5/config-errors-dialog.blp:9
+msgid "Ignore"
+msgstr "忽略"
+
+#: src/apprt/gtk/ui/1.5/config-errors-dialog.blp:10
+#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:97
+#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:95
+msgid "Reload Configuration"
+msgstr "重新載入設定"
+
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:6
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:6
msgid "Copy"
@@ -123,17 +146,12 @@
msgid "Open Configuration"
msgstr "開啟設定"
-#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:97
-#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:95
-msgid "Reload Configuration"
-msgstr "重新載入設定"
-
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:85
msgid "Terminal Inspector"
msgstr "終端機檢查工具"
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:102
-#: src/apprt/gtk/Window.zig:933
+#: src/apprt/gtk/Window.zig:960
msgid "About Ghostty"
msgstr "關於 Ghostty"
@@ -150,8 +168,7 @@
msgid ""
"An application is attempting to read from the clipboard. The current "
"clipboard contents are shown below."
-msgstr ""
-"有應用程式正嘗試讀取剪貼簿，目前的剪貼簿內容顯示如下。"
+msgstr "有應用程式正嘗試讀取剪貼簿，目前的剪貼簿內容顯示如下。"
#: src/apprt/gtk/ui/1.5/ccw-osc-52-read.blp:10
#: src/apprt/gtk/ui/1.5/ccw-osc-52-write.blp:10
@@ -167,8 +184,7 @@
msgid ""
"An application is attempting to write to the clipboard. The current "
"clipboard contents are shown below."
-msgstr ""
-"有應用程式正嘗試寫入剪貼簿，目前的剪貼簿內容顯示如下。"
+msgstr "有應用程式正嘗試寫入剪貼簿，目前的剪貼簿內容顯示如下。"
#: src/apprt/gtk/ui/1.5/ccw-paste.blp:6
msgid "Warning: Potentially Unsafe Paste"
@@ -178,31 +194,16 @@
msgid ""
"Pasting this text into the terminal may be dangerous as it looks like some "
"commands may be executed."
-msgstr ""
-"將這段文字貼到終端機具有潛在風險，因為它看起來像是可能會被執行的命令。"
+msgstr "將這段文字貼到終端機具有潛在風險，因為它看起來像是可能會被執行的命令。"
-#: src/apprt/gtk/Window.zig:199
-msgid "Main Menu"
-msgstr "主選單"
+#: src/apprt/gtk/inspector.zig:144
+msgid "Ghostty: Terminal Inspector"
+msgstr "Ghostty：終端機檢查工具"
-#: src/apprt/gtk/Window.zig:219
-msgid "View Open Tabs"
-msgstr "檢視開啟的分頁"
+#: src/apprt/gtk/Surface.zig:1243
+msgid "Copied to clipboard"
+msgstr "已複製到剪貼簿"
-#: src/apprt/gtk/Window.zig:265
-msgid ""
-"⚠️ You're running a debug build of Ghostty! Performance will be degraded."
-msgstr ""
-"⚠️ 您正在執行 Ghostty 的除錯版本！程式運作效能將會受到影響。"
-
-#: src/apprt/gtk/Window.zig:681
-msgid "Reloaded the configuration"
-msgstr "已重新載入設定"
-
-#: src/apprt/gtk/Window.zig:914
-msgid "Ghostty Developers"
-msgstr "Ghostty 開發者"
-
#: src/apprt/gtk/CloseDialog.zig:47
msgid "Close"
msgstr "關閉"
@@ -239,6 +240,23 @@
msgid "The currently running process in this split will be terminated."
msgstr "此分割區中目前執行的處理程序將被終止。"
-#: src/apprt/gtk/Surface.zig:1128
-msgid "Copied to clipboard"
-msgstr "已複製到剪貼簿"
+#: src/apprt/gtk/Window.zig:200
+msgid "Main Menu"
+msgstr "主選單"
+
+#: src/apprt/gtk/Window.zig:221
+msgid "View Open Tabs"
+msgstr "檢視開啟的分頁"
+
+#: src/apprt/gtk/Window.zig:295
+msgid ""
+"⚠️ You're running a debug build of Ghostty! Performance will be degraded."
+msgstr "⚠️ 您正在執行 Ghostty 的除錯版本！程式運作效能將會受到影響。"
+
+#: src/apprt/gtk/Window.zig:725
+msgid "Reloaded the configuration"
+msgstr "已重新載入設定"
+
+#: src/apprt/gtk/Window.zig:941
+msgid "Ghostty Developers"
+msgstr "Ghostty 開發者" |
On my way! |
🎉